[PHP 8.5] add new rule for filter_var #4553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvural
force-pushed
the
filter-var-rule
branch
from
fd1ff84 to
2c670a2
Compare
Collaborator
|
This pull request has been marked as ready for review. |
Comment on lines
+54
to
+56
| if ($this->filterFunctionReturnTypeHelper->hasFlag('FILTER_NULL_ON_FAILURE', $flagsType) | ||
| ->and($this->filterFunctionReturnTypeHelper->hasFlag('FILTER_THROW_ON_FAILURE', $flagsType)) | ||
| ->yes() |
Contributor
There was a problem hiding this comment.
Maybe you should also report maybe if reportMaybe is enabled.
But I'm unsure how good those filterFunctionReturnTypeHelper::hasFlag works so far
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4495
In PHP 8.5 using both
FILTER_THROW_ON_FAILUREandFILTER_NULL_ON_FAILUREat same time is not allowed. https://3v4l.org/Ibd4B/rfc#vgit.master_jitNot sure about the rule level and the message.